[PATCH] D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 14:43:07 PDT 2018


lebedev.ri added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:15
 
+#include <string.h>
 #include "asan_interceptors_memintrinsics.h"
----------------
kcc wrote:
> krytarowski wrote:
> > rationale?
> please don't. 
> this file should not include any system headers. 
Was passing of `-nostdinc` / `-nostdlib` / `-nostdlibinc` / `-nostdinc++` / `-nostdlib++` compiler options when building compiler-rt / xray been considered?
I wonder if that would help enforce these rules.


Repository:
  rL LLVM

https://reviews.llvm.org/D46454





More information about the llvm-commits mailing list