[PATCH] D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 13:53:15 PDT 2018


krytarowski added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:15
 
+#include <string.h>
 #include "asan_interceptors_memintrinsics.h"
----------------
rationale?


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:104
 #if ((SANITIZER_LINUX && !SANITIZER_ANDROID) || \
-  SANITIZER_FREEBSD || SANITIZER_OPENBSD) && !defined(PIC)
+  SANITIZER_FREEBSD || SANITIZER_OPENBSD || SANITIZER_RTEMS) && !defined(PIC)
 # define SANITIZER_CAN_USE_PREINIT_ARRAY 1
----------------
I think it will look better if we will split OSes here and document what linker, what versions supports what.


Repository:
  rL LLVM

https://reviews.llvm.org/D46454





More information about the llvm-commits mailing list