[PATCH] D46432: [llvm-exegesis] Add a library to cluster benchmark results.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:16
+
+// The clustering problem has the following characteristics:
+//  (A) - Low dimension (dimensions are typically proc resource units,
----------------
How about multiple runs? (with randomized registers and values)
Do we average them? Are they separate points?


================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:22
+//  (D) - The number of clusters is not known /a priory/.
+//  (E) - The amoint of noise is relatively small.
+// The problem is rather small. In terms of algorithms, (D) disqualifies
----------------
amount


================
Comment at: unittests/tools/llvm-exegesis/ClusteringTest.cpp:29
+  // Cluster around (x=0, y=1, z=2): points {0, 3}.
+  Points[0].Measurements = {{"x", 0.01, ""}, {"y", 1.02, ""}, {"z", 1.98, ""}};
+  Points[3].Measurements = {{"x", -0.01, ""}, {"y", 1.02, ""}, {"z", 1.98, ""}};
----------------
It may be OK to not set the last field (always "")


Repository:
  rL LLVM

https://reviews.llvm.org/D46432