[llvm] r331530 - [bindings/go] Add Go bindings for volatile loads/stores

[Roman Lebedev via llvm-commits]

Please keep lists as To:/CC:.

On Fri, May 4, 2018 at 10:52 PM, Dávid Bolvanský
<david.bolvansky at gmail.com> wrote:
> Hello,
>
> At first, sorry for it..
> I didnt ignore that page, I tried some ways but was unable to do it..
I'd advise caution with these "i tried, but it didn't work, so i just
kinda ignored it" approaches.

> I
> cannot find any exact command in LLVM manuals how to do it.
> arc commit has no such option to modify a commit message. I tried arc diff
> --edit and I got "Option '--edit' is not supported under svn. Edit revisions
> via the web interface when using SVN."
>
> Can you give any advice?

As with the commit message, not really, i don't use svn,
and i don't use arc to commit patches.
I'm using separate git repos + following
https://llvm.org/docs/Phabricator.html#git-svn-and-arcanist

> Thanks

Roman.

> 2018-05-04 17:37 GMT+02:00 Roman Lebedev <lebedev.ri at gmail.com>:
>>
>> It is important to retain the attribution of the changes.
>> https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes
>>
>> You may really want to read (or re-read) the documentation on the
>> development process:
>> https://llvm.org/docs/index.html#development-process-documentation
>>
>> On Fri, May 4, 2018 at 6:14 PM, David Bolvansky via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> > Author: xbolva00
>> > Date: Fri May  4 08:14:00 2018
>> > New Revision: 331530
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=331530&view=rev
>> > Log:
>> > [bindings/go] Add Go bindings for volatile loads/stores
>> >
>> > Reviewers: whitequark
>> >
>> > Reviewed By: whitequark
>> >
>> > Subscribers: llvm-commits
>> >
>> > Differential Revision: https://reviews.llvm.org/D46235
>> >
>> > Modified:
>> >     llvm/trunk/bindings/go/llvm/ir.go
>> >
>> > Modified: llvm/trunk/bindings/go/llvm/ir.go
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/llvm/trunk/bindings/go/llvm/ir.go?rev=331530&r1=331529&r2=331530&view=diff
>> >
>> > ==============================================================================
>> > --- llvm/trunk/bindings/go/llvm/ir.go (original)
>> > +++ llvm/trunk/bindings/go/llvm/ir.go Fri May  4 08:14:00 2018
>> > @@ -1037,6 +1037,8 @@ func (v Value) IsThreadLocal() bool
>> >  func (v Value) SetThreadLocal(tl bool)    { C.LLVMSetThreadLocal(v.C,
>> > boolToLLVMBool(tl)) }
>> >  func (v Value) IsGlobalConstant() bool    { return
>> > C.LLVMIsGlobalConstant(v.C) != 0 }
>> >  func (v Value) SetGlobalConstant(gc bool) {
>> > C.LLVMSetGlobalConstant(v.C, boolToLLVMBool(gc)) }
>> > +func (v Value) IsVolatile() bool          { return
>> > C.LLVMGetVolatile(v.C) != 0 }
>> > +func (v Value) SetVolatile(volatile bool) { C.LLVMSetVolatile(v.C,
>> > boolToLLVMBool(volatile)) }
>> >
>> >  // Operations on aliases
>> >  func AddAlias(m Module, t Type, aliasee Value, name string) (v Value) {
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>