[PATCH] D46284: [MachineLICM] Debug intrinsics shouldn't affect hoist decisions
Geoff Berry via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 4 12:31:42 PDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331549: [MachineLICM] Debug intrinsics shouldn't affect hoist decisions (authored by gberry, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D46284
Files:
llvm/trunk/lib/CodeGen/MachineLICM.cpp
llvm/trunk/test/CodeGen/AArch64/mlicm-stack-write-check.mir
Index: llvm/trunk/lib/CodeGen/MachineLICM.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/MachineLICM.cpp
+++ llvm/trunk/lib/CodeGen/MachineLICM.cpp
@@ -374,6 +374,10 @@
/// Return true if instruction stores to the specified frame.
static bool InstructionStoresToFI(const MachineInstr *MI, int FI) {
+ // Check mayStore before memory operands so that e.g. DBG_VALUEs will return
+ // true since they have no memory operands.
+ if (!MI->mayStore())
+ return false;
// If we lost memory operands, conservatively assume that the instruction
// writes to all slots.
if (MI->memoperands_empty())
Index: llvm/trunk/test/CodeGen/AArch64/mlicm-stack-write-check.mir
===================================================================
--- llvm/trunk/test/CodeGen/AArch64/mlicm-stack-write-check.mir
+++ llvm/trunk/test/CodeGen/AArch64/mlicm-stack-write-check.mir
@@ -0,0 +1,32 @@
+# RUN: llc -mtriple=aarch64 -run-pass machinelicm -verify-machineinstrs -o - %s | FileCheck %s
+---
+name: test
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: gpr64 }
+stack:
+ - { id: 0, size: 8, type: spill-slot }
+body: |
+ bb.0:
+ ; CHECK-LABEL: name: test
+ ; CHECK-LABEL: bb.0:
+ ; CHECK: $x2 = LDRXui %stack.0, 0
+ liveins: $x0, $x1, $x2
+ B %bb.1
+
+ bb.1:
+ ; CHECK-LABEL: bb.1:
+ ; CHECK-NOT: $x2 = LDRXui %stack.0, 0
+ liveins: $x0
+ DBG_VALUE %stack.0, 0
+ $x2 = LDRXui %stack.0, 0 :: (load 8 from %stack.0)
+ $x0 = ADDXrr $x0, $x2
+ $xzr = SUBSXri $x0, 1, 0, implicit-def $nzcv
+ Bcc 11, %bb.1, implicit $nzcv
+ B %bb.2
+
+ bb.2:
+ liveins: $x0
+ %0 = COPY $x0
+ %0 = COPY $x0 ; Force isSSA = false.
+...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46284.145253.patch
Type: text/x-patch
Size: 1728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180504/4ce48a44/attachment.bin>
More information about the llvm-commits
mailing list