[PATCH] D46396: Optionally simplify basic blocks introduced by AtomicExpandPass

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added inline comments.


================
Comment at: lib/Target/AArch64/AArch64TargetMachine.cpp:376
   if (TM->getOptLevel() != CodeGenOpt::None && EnableAtomicTidy)
     addPass(createCFGSimplificationPass(1, true, true, false, true));
 
----------------
ab wrote:
> This already does the simplification, no?  How about adding the pass for Hexagon as well?  I suppose this patch limits it to a smaller set of blocks, but on the other hand it's nice not to have to deal with it in the pass.
Evidently it doesn't a good enough job---check the testcase.  On Hexagon we don't want to run the full simplify-cfg.  I've tried that and it broke over 100 lit tests and I don't even know what impact it would have on performance.  This would be just a way too big of a hammer.


Repository:
  rL LLVM

https://reviews.llvm.org/D46396