[PATCH] D45841: Keep the output text sections with prefixes ".text.hot" , ".text.unlikely", ".text.startup", ".text.exit" separate

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:762-766
   Config->ZCombreloc = getZFlag(Args, "combreloc", "nocombreloc", true);
   Config->ZCopyreloc = getZFlag(Args, "copyreloc", "nocopyreloc", true);
+  Config->ZKeepTextSectionPrefix = getZFlag(
+      Args, "keep-text-section-prefix", "nokeep-text-section-prefix", false);
   Config->ZExecstack = getZFlag(Args, "execstack", "noexecstack", false);
----------------
Sort alphabetically.


================
Comment at: ELF/Writer.cpp:113
+  // sections with prefix ".text.hot", ".text.unlikely", ".text.startup" or
+  // ".text.exit".
+  if (Config->ZKeepTextSectionPrefix) {
----------------
Could you also mention why you want to do that in the first place? In this case the intention of doing this is more important than what we are doing for future readers.


================
Comment at: ELF/Writer.cpp:119-120
+        return V.drop_back();
+    }
+  }
+
----------------
nit: remove {}


https://reviews.llvm.org/D45841