[PATCH] D46440: [lit, lldbsuite] Fixes for several tests LLDB tests for Python 3 or Windows

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added inline comments.


================
Comment at: packages/Python/lldbsuite/test/python_api/hello_world/main.c:20
     while (1) 
         sleep (1); // Waiting to be attached...
 
----------------
zturner wrote:
> On posix this is a number of seconds, but on Windows this is a number of milliseconds.  So perhaps your macro above should be `#define sleep(x) Sleep((x) * 1000)`.  Thoughts?
Good catch! The test is happily passing either way in our setup, but it will be better to update it. I'll make the change.


Repository:
  rL LLVM

https://reviews.llvm.org/D46440