[PATCH] D46039: Fix compile time hang in LSR

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 09:02:47 PDT 2018


qcolombet added inline comments.


================
Comment at: test/Transforms/LoopStrengthReduce/lsr-comp-time.ll:1
+; RUN: opt -loop-reduce -disable-output < %s
+; Test checks compile time is reasonable (no hang for ~10 minutes).
----------------
Check that we generate something sensible.
Not hanging is not a good enough test.


================
Comment at: test/Transforms/LoopStrengthReduce/lsr-comp-time.ll:12
+  %4 = icmp eq i32 %1, 0
+  br i1 %4, label %101, label %5
+
----------------
Use `opt -instnamer`


Repository:
  rL LLVM

https://reviews.llvm.org/D46039





More information about the llvm-commits mailing list