[PATCH] D46315: [RegUsageInfoCollector] Fix handling of callee saved registers with CSR optimization.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Jonas,

Thanks for the explanation.
I missed that the call to getCallPreservedMask was guarded by isSafeForNoCSROpt.

Given the default implementation of determineCalleeSaves is already guarded by isSafeForNoCSROpt, I think the patch makes a lot of sense.

LGTM.

Cheers,
-Quentin



================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:149
+          << " function optimized for not having CSR.\n");
   }
 
----------------
This logging is not very useful now. I would get rid of it.


https://reviews.llvm.org/D46315