[PATCH] D46076: [PPC64] Replace several endianess checks with abi checks.

[Sean Fertile via Phabricator via llvm-commits]

sfertile abandoned this revision.
sfertile added a comment.

In https://reviews.llvm.org/D46076#1083405, @echristo wrote:

> This LGTM FWIW. (Acking to have it pop back up in people's queues).


Thanks for review.

I was using this to help cleanup some of the checks in the Plt stub and glink patches as well as run some of the lit tests for both BE and LE.  https://reviews.llvm.org/D46316 (remove support for V1 abi)  is approved, so  I think I can abandon this and cleanup the dependent patches to not need this check.



================
Comment at: ELF/Target.h:157-161
+// Checks for abi version 2 when targeting PPC64.
+bool isPPC64ElfV2();
+
 uint64_t getPPC64TocBase();
 uint64_t getAArch64Page(uint64_t Expr);
----------------
echristo wrote:
> IMO this is going to get unwieldy after a while (making it part of the base class), but it looks like you're also just following existing practice.
I agree, I would have liked to sink this into the PPC64 target directly. If the targets were setup with the LLVM style RTTI then I would have done it this way.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46076