[llvm] r331509 - [RegUsageInfoCollector] Bugfix for handling of register aliases.

[Jonas Paulsson via llvm-commits]

Author: jonpa
Date: Fri May  4 00:50:05 2018
New Revision: 331509

URL: http://llvm.org/viewvc/llvm-project?rev=331509&view=rev
Log:
[RegUsageInfoCollector]  Bugfix for handling of register aliases.

Don't assume the alias of a defined reg is always already in the set.

As the test case in https://bugs.llvm.org/show_bug.cgi?id=36587 discovered,
it is wrong to assume that all the aliases of the defined register in the
*current function* is already present in the UsedPhysRegsMask.

This patch changes this so that any definition in the current function of a
phys-reg always results in all its aliases inserted into the set of defined
registers.

Review: Quentin Colombet
https://reviews.llvm.org/D45157

Added:
    llvm/trunk/test/CodeGen/SystemZ/ipra.ll
Modified:
    llvm/trunk/lib/CodeGen/RegUsageInfoCollector.cpp

Modified: llvm/trunk/lib/CodeGen/RegUsageInfoCollector.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegUsageInfoCollector.cpp?rev=331509&r1=331508&r2=331509&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/RegUsageInfoCollector.cpp (original)
+++ llvm/trunk/lib/CodeGen/RegUsageInfoCollector.cpp Fri May  4 00:50:05 2018
@@ -110,19 +110,18 @@ bool RegUsageInfoCollector::runOnMachine
   // Scan all the physical registers. When a register is defined in the current
   // function set it and all the aliasing registers as defined in the regmask.
   for (unsigned PReg = 1, PRegE = TRI->getNumRegs(); PReg < PRegE; ++PReg) {
-    // If a register is in the UsedPhysRegsMask set then mark it as defined.
-    // All it's aliases will also be in the set, so we can skip setting
-    // as defined all the aliases here.
-    if (UsedPhysRegsMask.test(PReg)) {
-      SetRegAsDefined(PReg);
-      continue;
-    }
     // If a register is defined by an instruction mark it as defined together
     // with all it's aliases.
     if (!MRI->def_empty(PReg)) {
       for (MCRegAliasIterator AI(PReg, TRI, true); AI.isValid(); ++AI)
         SetRegAsDefined(*AI);
+      continue;
     }
+    // If a register is in the UsedPhysRegsMask set then mark it as defined.
+    // All clobbered aliases will also be in the set, so we can skip setting
+    // as defined all the aliases here.
+    if (UsedPhysRegsMask.test(PReg))
+      SetRegAsDefined(PReg);
   }
 
   if (!TargetFrameLowering::isSafeForNoCSROpt(F)) {

Added: llvm/trunk/test/CodeGen/SystemZ/ipra.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/SystemZ/ipra.ll?rev=331509&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/SystemZ/ipra.ll (added)
+++ llvm/trunk/test/CodeGen/SystemZ/ipra.ll Fri May  4 00:50:05 2018
@@ -0,0 +1,45 @@
+; Test that the set of used phys regs used by interprocedural register
+; allocation is correct for a test case where the called function (@fn2)
+; itself has a call (to @fn1). @fn1 defines %r0l, while @fn2 defines
+; %r0d. The RegUsageInfo for @fn2 must include %r0h.
+;
+; RUN: llc -mtriple=s390x-linux-gnu -mcpu=z13 -enable-ipra -print-regusage 2>&1 < %s \
+; RUN:   | FileCheck %s
+;
+; CHECK: fn2 Clobbered Registers: {{.*}} $r0h
+
+ at h = external global [0 x i32], align 4
+ at n = external global i32*, align 8
+
+define void @fn1() {
+bb:
+  br label %bb1
+
+bb1:                                              ; preds = %bb1, %bb
+  %tmp = getelementptr inbounds [0 x i32], [0 x i32]* @h, i64 0, i64 undef
+  %tmp2 = load i32, i32* %tmp
+  store i32 %tmp2, i32* undef
+  br label %bb1
+}
+
+define void @fn2() {
+bb:
+  br label %bb1
+
+bb1:                                              ; preds = %bb
+  br i1 undef, label %bb2, label %bb3
+
+bb2:                                              ; preds = %bb1
+  store i32* null, i32** @n
+  unreachable
+
+bb3:                                              ; preds = %bb1
+  call void @fn1()
+  unreachable
+}
+
+define void @main() {
+bb:
+  call void @fn2()
+  ret void
+}