[PATCH] D46246: [XRay][compiler-rt] Support string-based config for Basic mode.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_basic_logging.cc:400
+    P.ParseString(EnvOpts);
+    if (internal_strlen(EnvOpts) == 0) {
+      F.func_duration_threshold_us =
----------------
kpw wrote:
> Shoudn't this be != 0? Override the defaults if XRAY_BASIC_OPTIONS was not empty?
No, what we want to do is to use the "global" version (ones defined in `XRAY_OPTIONS`) only if `XRAY_BASIC_OPTIONS` wasn't defined. Added a comment.


https://reviews.llvm.org/D46246