[PATCH] D46366: AMDGPU: Add D16 instructions preserve unused bits feature
Konstantin Zhuravlyov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 3 20:39:53 PDT 2018
kzhuravl marked an inline comment as done.
kzhuravl added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPU.td:319-323
+def FeatureD16HIInsts : SubtargetFeature<"d16-hi-insts",
+ "HasD16HIInsts",
+ "true",
+ "Has D16_HI instructions"
+>;
----------------
arsenm wrote:
> arsenm wrote:
> > This isn't the right to handle this. The instructions themselves do exist, so should not be dependent on a subtarget feature. The assembler/disassembler should still accept them. This should be a separately named feature
> We also still can select them, just under different circumstances
Can this be done in a separate change?
https://reviews.llvm.org/D46366
More information about the llvm-commits
mailing list