[PATCH] D46338: [GlobalISel][Legalizer] LegalizerInfo verifier: checking that legalization rules cover all type indices

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 18:17:18 PDT 2018


rtereshin added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-2.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
+
----------------
qcolombet wrote:
> Ditto.
I think I'm going to put a `not llc` in the follow up (https://reviews.llvm.org/D46414), and then make these tests here in his patch exactly the same, but with XFAIL. And put the comment as suggested above. That would probably make most sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D46338





More information about the llvm-commits mailing list