[PATCH] D46338: [GlobalISel][Legalizer] LegalizerInfo verifier: checking that legalization rules cover all type indices

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Couple of nits on the tests.



================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-1.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
+
----------------
Could you add a comment explaining what you are testing in this test case?
Basically why is it useful? :)

Shouldn't we run `not llc`?


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-2.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
+
----------------
Ditto.


Repository:
  rL LLVM

https://reviews.llvm.org/D46338