[PATCH] D45604: Support for multiarch runtimes layout

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In https://reviews.llvm.org/D45604#1084815, @phosek wrote:

> I've modified the patch following @rnk suggestion, the new layout is enabled by a single CMake option `CLANG_ENABLE_PER_TARGET_RUNTIME_DIR`. I'm still working on fixing tests, but I've tested the build and it's working for both `runtimes/` and `projects/` layout. Let me know what you think.


One issue I ran into while working on getting tests to work is that in the current patch, enabling `CLANG_ENABLE_PER_TARGET_RUNTIME_DIR` enables the new layout in the driver and disables the old one (e.g. when constructing compiler-rt paths). However, there are plenty of tests that hardcode the `libclang_rt.builtins-<arch>.a` name and those would all have to be disabled when the new layout is enabled. Maybe it'd be better to only enable the new layout but support fallback back onto the old one (i.e. search both the new and the old path for compiler-rt libraries)?


Repository:
  rL LLVM

https://reviews.llvm.org/D45604