[PATCH] D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added a comment.

Re: bloat, is the consensus that we just don't add to instcombine any more?

This thread http://lists.llvm.org/pipermail/llvm-dev/2017-July/115398.html seemed to have concluded that it’s still acceptable to add to instcombine?

If instcombine is going to be split into multiple passes, assuming we can't call instcombine simplification routines from another pass (unlike instsimplify), could we end up with a situation where we would need to run another pass and instcombine in turn multiple times until a fix point? I'm not sure if any of the extra things that are currently (or proposed to be) part of instcombine are in fact like this and is in instcombine because of this. For example, factorization may open up new other instcombine opportunities, which in turn opens up more factorization opportunities, etc. Anyhow, it seems non-trivial.


Repository:
  rL LLVM

https://reviews.llvm.org/D46336