[PATCH] D45492: [Verifier] Check for TBAA Access Tag presence

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri planned changes to this revision.
lebedev.ri added a comment.

Thank you @kosarev, i will dig deeper.



================
Comment at: lib/IR/Verifier.cpp:5037-5038
+bool TBAAVerifier::ShouldHaveTBAAAccessTag(Instruction &I) {
+  return isa<LoadInst>(I) || isa<StoreInst>(I) || isa<VAArgInst>(I) ||
+         isa<AtomicRMWInst>(I) || isa<AtomicCmpXchgInst>(I);
+}
----------------
kosarev wrote:
> We generate a significant amount of such instructions that are not supposed to be decorated. See for example D41562 and D39138. For my local experiments I was adding marks associated with load and store instructions that give a clue on their origin. If we can have such a mechanism in the mainline to make things like this patch more useful, then that would be great.
> We generate a significant amount of such instructions that are not supposed to be decorated.
Aha, interesting.

> For my local experiments I was adding marks associated with load and store instructions that give a clue on their origin.

I did not look into details, but that sounds bad. It's kind-of a 'chicken and egg' problem.
We'd basically need a verifier to make sure *that* info is not lost :/



Repository:
  rL LLVM

https://reviews.llvm.org/D45492