[PATCH] D46221: [RISCV] Implement MC layer support for the tail pseudoinstruction

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 12:05:57 PDT 2018


mgrang added inline comments.


================
Comment at: test/CodeGen/RISCV/tail-calls.ll:1
+; RUN: llc -mtriple riscv32-unknown-linux-gnu -o - %s | FileCheck %s
+; RUN: llc -mtriple riscv32-unknown-elf       -o - %s | FileCheck %s
----------------
mgrang wrote:
> Note: I have limited this test only to riscv32. With riscv64 I get the following error for fp128 parameter:
> LLVM ERROR: Cannot select: t17: i64 = Constant<4611404543450677248>
> 
> I guess I can restrict only the failing test to riscv32 but I felt it was cleaner this way. We could enable this for riscv64 once the support for fp128 in riscv64 is more mature.
> 
> @asb What do you suggest?
Please disregard the above comment. It was meant to be added to D45395.


https://reviews.llvm.org/D46221





More information about the llvm-commits mailing list