[PATCH] D46401: Fix another case where libstdc++ is being inappropriately requested (see r328775) for all platforms.

[Dan Liew via Phabricator via llvm-commits]

delcypher created this revision.
delcypher added reviewers: kubamracek, Hahnfeld, kcc.
Herald added a subscriber: Sanitizers.

Fix another case where libstdc++ is being inappropriately requested (see
r328775) for all platforms.

Given that this is the second occurance of this problem it seemed worth
fixing this problem in a more generic way. r328775 has been reverted and
now a substitution `%linux_static_libstdcplusplus` has been provided.
This substitution expands to Clang driver arguments to use a static
libstdc++ on Linux and on all other platforms it expands to nothing.

The `asan/TestCases/throw_invoke_test.cc` and
`test/tsan/static_init6.cc` test cases now use this substitution.

rdar://problem/39948818


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46401

Files:
  test/asan/TestCases/Linux/throw_invoke_test_libstdcxx.cc
  test/asan/TestCases/throw_invoke_test.cc
  test/lit.common.cfg
  test/tsan/static_init6.cc


Index: test/tsan/static_init6.cc
===================================================================
--- test/tsan/static_init6.cc
+++ test/tsan/static_init6.cc
@@ -1,4 +1,5 @@
-// RUN: %clangxx_tsan -stdlib=libstdc++ -static-libstdc++ -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_tsan %linux_static_libstdcplusplus -O1 %s -o %t && %run %t 2>&1
+// | FileCheck %s
 #include <pthread.h>
 #include <stdlib.h>
 #include <stdio.h>
Index: test/lit.common.cfg
===================================================================
--- test/lit.common.cfg
+++ test/lit.common.cfg
@@ -322,6 +322,14 @@
   config.substitutions.append( ("%ld_flags_rpath_exe", "-Wl,-R\$ORIGIN -L%T -l%xdynamiclib_namespec") )
   config.substitutions.append( ("%ld_flags_rpath_so", '') )
 
+# Provide a substituion that can be used to tell Clang to use a static libstdc++.
+# The substitution expands to nothing on non Linux platforms.
+# FIXME: This should check the target OS, not the host OS.
+if config.host_os == 'Linux':
+  config.substitutions.append( ("%linux_static_libstdcplusplus", "-stdlib=libstdc++ -static-libstdc++") )
+else:
+  config.substitutions.append( ("%linux_static_libstdcplusplus", "") )
+
 # Must be defined after the substitutions that use %dynamiclib.
 config.substitutions.append( ("%dynamiclib", '%T/%xdynamiclib_filename') )
 config.substitutions.append( ("%xdynamiclib_filename", 'lib%xdynamiclib_namespec.so') )
Index: test/asan/TestCases/throw_invoke_test.cc
===================================================================
--- test/asan/TestCases/throw_invoke_test.cc
+++ test/asan/TestCases/throw_invoke_test.cc
@@ -1,4 +1,5 @@
 // RUN: %clangxx_asan %s -o %t && %run %t
+// RUN: %clangxx_asan %s -o %t %linux_static_libstdcplusplus && %run %t
 
 #include <stdio.h>
 static volatile int zero = 0;
Index: test/asan/TestCases/Linux/throw_invoke_test_libstdcxx.cc
===================================================================
--- test/asan/TestCases/Linux/throw_invoke_test_libstdcxx.cc
+++ /dev/null
@@ -1,48 +0,0 @@
-// This the basically the `throw_invoke_test.cc` test but using libstdc++
-// instead of the default.
-// RUN: %clangxx_asan %s -o %t -stdlib=libstdc++ -static-libstdc++ && %run %t
-
-#include <stdio.h>
-static volatile int zero = 0;
-inline void pretend_to_do_something(void *x) {
-  __asm__ __volatile__("" : : "r"(x) : "memory");
-}
-
-__attribute__((noinline)) void ReallyThrow() {
-  fprintf(stderr, "ReallyThrow\n");
-  try {
-    if (zero == 0)
-      throw 42;
-    else if (zero == 1)
-      throw 1.;
-  } catch (double x) {
-  }
-}
-
-__attribute__((noinline)) void Throw() {
-  int a, b, c, d, e;
-  pretend_to_do_something(&a);
-  pretend_to_do_something(&b);
-  pretend_to_do_something(&c);
-  pretend_to_do_something(&d);
-  pretend_to_do_something(&e);
-  fprintf(stderr, "Throw stack = %p\n", &a);
-  ReallyThrow();
-}
-
-__attribute__((noinline)) void CheckStack() {
-  int ar[100];
-  pretend_to_do_something(ar);
-  for (int i = 0; i < 100; i++)
-    ar[i] = i;
-  fprintf(stderr, "CheckStack stack = %p, %p\n", ar, ar + 100);
-}
-
-int main(int argc, char **argv) {
-  try {
-    Throw();
-  } catch (int a) {
-    fprintf(stderr, "a = %d\n", a);
-  }
-  CheckStack();
-}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46401.145063.patch
Type: text/x-patch
Size: 3240 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180503/4a34dbc2/attachment.bin>