[PATCH] D45732: [GlobalISel] Making VRegs w/ LLTs and RegClasses both illegal
Roman Tereshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 3 11:50:31 PDT 2018
rtereshin added a comment.
In https://reviews.llvm.org/D45732#1086494, @aditya_nandakumar wrote:
> Also, I wonder if there would be passes (non ISEL), that would break the invariant intra pass, but cleans up at the end of the pass..
I don't know, maybe? It's probably not going too much against this patch, I just decided to maintain invariant intra pass to make this work for existing passes. New passes are free to make a different decision and clean up at the end of the pass, they will have the opportunity to call the constrain reg classes helper functions and methods with `ISel = true` to stop them from maintaining the invariant. If that happens, we will rename the function argument so it doesn't suggest instruction select pass specifically anymore.
Sounds good?
Also, thanks for looking into this.
Repository:
rL LLVM
https://reviews.llvm.org/D45732
More information about the llvm-commits
mailing list