[PATCH] D46372: Update ThinLTO test

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 11:46:42 PDT 2018


pcc added inline comments.


================
Comment at: lld/ELF/LTO.cpp:199
   // Create the empty files which, if indexed, will be overwritten later.
-  writeEmptyDistributedBuildOutputs(Obj.getName(), OldPrefix, NewPrefix, false);
+  if (Config->ThinLTOIndexOnly)
+    writeEmptyDistributedBuildOutputs(Obj.getName(), OldPrefix, NewPrefix,
----------------
grimar wrote:
> grimar wrote:
> > This needs a test case. 
> > 
> > Actually, this part should have been in a different patch from "Updated thinLTO test to not include forward or backward slash for testing." part.
> .. because fixing windows BB failures (I guess) is different from changing the functionality.
Yes, this should have included a test. @rdhindsa can you please add one?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46372





More information about the llvm-commits mailing list