[PATCH] D46400: Add support for thinlto option to emit import files for thinlink

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/LTO.cpp:102
+  if (Config->ThinLTOEmitImportsFiles) {
+    raw_fd_ostream OS(NewModulePath + ".imports", EC,
+                      sys::fs::OpenFlags::F_None);
----------------
I don't understand this part of code. I think OS will be closed at end of this `if` block, so I don't think you are writing anything to the file. Is this code correct?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46400