[PATCH] D46399: Skip blocks with no predecessors for CFIInstrInserter verify

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:296
     const MBBCFAInfo &CurrMBBInfo = MBBVector[CurrMBB.getNumber()];
+    if (CurrMBB.getNumber() != MF.front().getNumber() && !CurrMBB.pred_size())
+      continue;
----------------
pred_empty()?


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:296
     const MBBCFAInfo &CurrMBBInfo = MBBVector[CurrMBB.getNumber()];
+    if (CurrMBB.getNumber() != MF.front().getNumber() && !CurrMBB.pred_size())
+      continue;
----------------
craig.topper wrote:
> pred_empty()?
Can't you just check CurrMBB == MF.front()? This applies to several other places in this pass.


Repository:
  rL LLVM

https://reviews.llvm.org/D46399