[PATCH] D46391: [DebugInfo] Correction for an assert in DIExpression::createFragmentExpression

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: lib/IR/DebugInfoMetadata.cpp:832
         // Make the new offset point into the existing fragment.
         uint64_t FragmentOffsetInBits = Op.getArg(0);
         // Op.getArg(0) is FragmentOffsetInBits.
----------------
aprantl wrote:
> Actually this comment is silly, too:
> ```
>         uint64_t FragmentOffsetInBits = Op.getArg(0);
>         uint64_t FragmentSizeInBits = Op.getArg(1);
>         (void)FragmentSizeInBits;
>         assert((OffsetInBits + SizeInBits <= FragmentSizeInBits) && ....);
> ```
Ok, I'll fix that as well. Thanks for the review!


Repository:
  rL LLVM

https://reviews.llvm.org/D46391