[PATCH] D45948: [MIRParser] Allow register class names in the form of integer/scalar

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 05:10:12 PDT 2018


thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

LGTM with a small refactoring. I would wait until tomorrow for other reviewers to react, if not you can go ahead and commit this.



================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1307
+  if (Token.range().front() == 's' || Token.range().front() == 'p')
+    for (auto C : Token.range().drop_front())
+      if (!isdigit(C))
----------------
Can we refactor this into a function?


Repository:
  rL LLVM

https://reviews.llvm.org/D45948





More information about the llvm-commits mailing list