[PATCH] D46365: AMDGPU: Separate R600 and GCN TableGen files

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUMCInstLower.cpp:141
+
+  if (STI.getTargetTriple().getArch() == Triple::amdgcn) {
+    const auto *TII = static_cast<const SIInstrInfo*>(STI.getInstrInfo());
----------------
Should this be a separate class as well?


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:66
+  virtual bool isAmdHsaOS() const = 0;
+  virtual bool isAmdPalOS() const = 0;
+  virtual bool has16BitInsts() const = 0;
----------------
Is it possible to avoid making these virtual?


Repository:
  rL LLVM

https://reviews.llvm.org/D46365