[PATCH] D46369: [llvm-objcopy] Add --strip-symbol (-N) option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

In https://reviews.llvm.org/D46369#1086121, @jhenderson wrote:

> What happens if the requested symbol is a) referred to by a relocation? b) The signature symbol for a group section?
>
> There might be other cases I haven't thought of either.
>
> Please add tests for this and show that the behaviour is sensible.


Well, I thought we concurred in a previous review that we were letting the user do what he wanted, even if it was not making sense.
But, to answer your questions, as you already guessed, for those two cases, objcopy doesn't do anything with the symbols, as it doesn't make any sense to strip them.
That's why I didn't add any tests for those one, as we are not handling symbols differently anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D46369