[PATCH] D44677: [SCEV] Make computeExitLimit more simple and more powerful

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 20:31:45 PDT 2018


mkazantsev added a comment.

I am not sure that we actually break the invariant which was preserved before. Note that all recent failures we have seen were on assert from the patch https://reviews.llvm.org/D44676. We might as well just break this invariant previously, but without this assert we did not know about it.

As for the invariant itself, SCEV assumes that CFG did not change because it keeps mapping of blocks to exit counts for these blocks. Whenever we change the CFG and, for example, change some domination relationship between blocks, we must invalidate the cache.


Repository:
  rL LLVM

https://reviews.llvm.org/D44677





More information about the llvm-commits mailing list