[PATCH] D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 15:55:22 PDT 2018


yamauchi added a comment.

In https://reviews.llvm.org/D46336#1085279, @spatel wrote:

> I think part of this has already landed with:
>  https://reviews.llvm.org/rL331311
>
> There are proposals trying to do reassociation in a more complete way outside of instcombine:
>  https://reviews.llvm.org/D45842 (this would catch the cases that I recently added to and-xor-or.ll)
>  https://reviews.llvm.org/D41574
>
> This is a response to discussions on llvm-dev that instcombine is already trying to do too much. This patch goes against that idea.


Looks like some related issues are being looked into.

Where’s this discussion, and what’s the concern? Compile time?


Repository:
  rL LLVM

https://reviews.llvm.org/D46336





More information about the llvm-commits mailing list