[PATCH] D42848: Correct dwarf unwind information in function epilogue
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 2 15:35:25 PDT 2018
craig.topper added inline comments.
================
Comment at: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp:426
+ Offset = PI->getOperand(2).getImm();
} else if ((Opc == X86::LEA32r || Opc == X86::LEA64_32r) &&
PI->getOperand(0).getReg() == StackPtr &&
----------------
Should this be handling LEA64r too? That's the LEA instruction for 64-bit mode. LEA64_32r is created by two address instruction pass when an ADD needs to be made 3 three address to avoid destroying its input registers. It would surprised if LEA64_32r was ever used with a stack pointer.
Repository:
rL LLVM
https://reviews.llvm.org/D42848
More information about the llvm-commits
mailing list