[PATCH] D46366: AMDGPU: Separate D16_HI into its own feature
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 2 15:25:02 PDT 2018
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPU.td:319-323
+def FeatureD16HIInsts : SubtargetFeature<"d16-hi-insts",
+ "HasD16HIInsts",
+ "true",
+ "Has D16_HI instructions"
+>;
----------------
This isn't the right to handle this. The instructions themselves do exist, so should not be dependent on a subtarget feature. The assembler/disassembler should still accept them. This should be a separately named feature
https://reviews.llvm.org/D46366
More information about the llvm-commits
mailing list