[PATCH] D46358: [llvm-cvtres] Allow parameters preceded by '-' in addition to '/'

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 14:05:56 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D46358#1085711, @amccarth wrote:

> I'm mildly concerned about the tests that give filenames with forward slashes.  That doesn't work with a lot of Windows command lines, but apparently the tests here were already doing that.


Yup - especially for the case when invoked from msys, parameters with slashes can occasionally be made into absolute paths (although the cvtres ones don't have that problem), which is why I prefer to consistently use dashes if possible.


Repository:
  rL LLVM

https://reviews.llvm.org/D46358





More information about the llvm-commits mailing list