[PATCH] D45734: [reassociate] Fix excessive revisits when processing long chains of reassociatable instructions.

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added inline comments.


================
Comment at: test/Transforms/Reassociate/long-chains.ll:31
+; CHECK: 55 reassociate - Number of insts reassociated
+; CHECK:  3 reassociate - Number of multiplies factored
----------------
dsanders wrote:
> dberlin wrote:
> > Is it possible to check the number of visits is within a range?
> > 
> > (IE 100-200, and not 1 million)?
> > 
> > I don't remember if lit can do this :(
> I don't think it can do ranges but orders of magnitude are possible by matching a fixed number of digits with something like:
>   ; CHECK: {{[1-9][0-9]}} reassociate - Number of insts reassociated
> Would you like me to change it to that?
Yeah, why don't we do that just so it doesn't get messed up by random changes.
We really care about the order of magnitude, not the exact number.

(I think :-P)


Repository:
  rL LLVM

https://reviews.llvm.org/D45734