[PATCH] D46356: [TableGen] Emit a fatal error on inconsistencies in resource units vs cycles.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 08:14:34 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D46356#1085333, @courbet wrote:

> In https://reviews.llvm.org/D46356#1085328, @RKSimon wrote:
>
> > I think it'd be clearer if we could keep Btver2/Znver1 to the Res = [1] default tbh
>
>
> Hm, not sure how I can do that without triggering the check for  cases when the user erroneously specified `[1]` when they wanted to use the default (now `[]`). Did I miss a possibility ?
>  This makes is no difference for the user, but allows more checking. Best of both worlds ? :)


Which cases fail?


Repository:
  rL LLVM

https://reviews.llvm.org/D46356





More information about the llvm-commits mailing list