[PATCH] D46356: [TableGen] Emit a fatal error on inconsistencies in resource units vs cycles.
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 2 07:43:49 PDT 2018
andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.
Thanks Clement,
It looks good to me now. I only have one minor nit (see below).
================
Comment at: utils/TableGen/SubtargetEmitter.cpp:1123
+ }
+ // TODO(courbet): check NumMicroOps.
+
----------------
andreadb wrote:
> Please remove this TODO (or remove your name from the TODO comment).
This comment should be modified or removed.
Repository:
rL LLVM
https://reviews.llvm.org/D46356
More information about the llvm-commits
mailing list