[PATCH] D46356: [TableGen] Emit a fatal error on inconsistencies in resource units vs cycles.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 05:42:43 PDT 2018


courbet added a comment.

In https://reviews.llvm.org/D46356#1085159, @RKSimon wrote:

> Not sure if I want to have to specify resource cycles every time - we should be able to assume a default=1, same for latency and micro-ops. This helps reduce bulkiness of the models considerably. In fact I might go further and maybe suggest a debug warning that values set to the default value could be removed?


OK, I've changed `list<int> Res = [1]` to `list<int> Res = []` in the definition of `JWriteResFpuPair`, and added a condition so that the folded version avoids the concat when relying in the default.


Repository:
  rL LLVM

https://reviews.llvm.org/D46356





More information about the llvm-commits mailing list