[compiler-rt] r331324 - [libFuzzer] Don't short-circuit from CrashCallback.

Matt Morehouse via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 19:55:28 PDT 2018


Author: morehouse
Date: Tue May  1 19:55:28 2018
New Revision: 331324

URL: http://llvm.org/viewvc/llvm-project?rev=331324&view=rev
Log:
[libFuzzer] Don't short-circuit from CrashCallback.

Short-circuiting causes tests to fail on Mac since libFuzzer crashes
rather than exiting with an error code when an unexpected signal
happens.

Modified:
    compiler-rt/trunk/lib/fuzzer/FuzzerLoop.cpp

Modified: compiler-rt/trunk/lib/fuzzer/FuzzerLoop.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/fuzzer/FuzzerLoop.cpp?rev=331324&r1=331323&r2=331324&view=diff
==============================================================================
--- compiler-rt/trunk/lib/fuzzer/FuzzerLoop.cpp (original)
+++ compiler-rt/trunk/lib/fuzzer/FuzzerLoop.cpp Tue May  1 19:55:28 2018
@@ -228,9 +228,8 @@ void Fuzzer::StaticFileSizeExceedCallbac
 }
 
 void Fuzzer::CrashCallback() {
-  if (EF->__sanitizer_acquire_crash_state &&
-      !EF->__sanitizer_acquire_crash_state())
-    return;
+  if (EF->__sanitizer_acquire_crash_state)
+    EF->__sanitizer_acquire_crash_state();
   Printf("==%lu== ERROR: libFuzzer: deadly signal\n", GetPid());
   if (EF->__sanitizer_print_stack_trace)
     EF->__sanitizer_print_stack_trace();




More information about the llvm-commits mailing list