[PATCH] D46217: [llvm-objcopy] Add --weaken option

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

I'm happy with this change. I think we should change --globalize and --localize to match but if --globalize-symbol or --localize-symbol is used it shouldn't bother checking; if people want to do non-sense that's their choice. I didn't think about it but it makes a lot of sense not to globalize weak symbols and it makes sense to not localize undefined symbols. So I think the choices objcopy chose makes sense. If you could change those to match that, it would be awesome!


Repository:
  rL LLVM

https://reviews.llvm.org/D46217