[PATCH] D46259: [CFLGraph][NFC] Simplify/reorder switch in visitConstantExpr

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/trunk/lib/Analysis/CFLGraph.h:548
-        break;
-      }
-      case Instruction::InsertElement: {
----------------
xbolva00 wrote:
> efriedma wrote:
> > The logic for selects looks suspicious; operand 0 is the condition.
> Yep true. Seems like this is quite an old bug here.
> 
> We should use operands 1 and 2 here.
> 
> I will post a new patch tomorrow.
Can you look on it?

https://reviews.llvm.org/D46343

Thanks :)


Repository:
  rL LLVM

https://reviews.llvm.org/D46259