[PATCH] D45022: [X86] Mark all byval parameters as aliased

[Warren Ristow via Phabricator via llvm-commits]

wristow added a comment.

A couple minor test-tweak comments in-line.
As before, the code-change looks safe and conservative to me, in terms of the aliasing.  And my guess is that conservative aspect is fine, in that it won't seriously impact performance.  So I'm happy to say LGTM.  Does anyone with more experience in this area have any concerns?



================
Comment at: test/CodeGen/X86/pr30290.ll:2
+; RUN: llc -mcpu=btver2 %s -stop-after post-RA-sched -o - | FileCheck %s
+; Test desc: two functions (foo, bar) with byval arguments, should not have
+; reads/writes from/to byval storage re-ordered.
----------------
'bar' or 'baz'?


================
Comment at: test/CodeGen/X86/pr30290.ll:19
+  store i32 1, i32* %3, align 8
+; XXX XXX XXX
+; Fault happens here: five "1" constants have just been written into the byval
----------------
Remove this XXX line?


https://reviews.llvm.org/D45022