[PATCH] D46259: [CFLGraph][NFC] Simplify/reorder switch in visitConstantExpr
John McCall via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 1 14:18:54 PDT 2018
rjmccall added a comment.
I hate to keep making these picky comments, but I don't know what you're trying to do with the braces now. You're adding braces on some of these cases, you're removing them from others, it's all inconsistent. I think it's almost always best to have braces on cases, unless they're just a single-line return or something; so please at least leave the existing braces where they are, and maybe add braces to cases if they don't have them.
https://reviews.llvm.org/D46259
More information about the llvm-commits
mailing list