[PATCH] D46277: [libFuzzer] Report at most one crash per input.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 13:46:19 PDT 2018


morehouse marked 3 inline comments as done.
morehouse added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h:59
+  // simultaneously.
+  SANITIZER_INTERFACE_ATTRIBUTE bool __sanitizer_acquire_crash_state();
+
----------------
kcc wrote:
> Since this is used by libFuzzer, it's not an internal interface, but a public one, so move it to include/sanitizer/common_interface_defs.h
> Also, make it return int, to make more C-friendly, update the comment accordingly. 
Still kept this declaration also, following the pattern of other public interfaces that are defined internally.


https://reviews.llvm.org/D46277





More information about the llvm-commits mailing list