[PATCH] D46330: Create a MachineBasicBlock for created IR-level BasicBlock

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 13:30:58 PDT 2018


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Good catch, thanks! LGTM



================
Comment at: lib/Target/X86/X86RetpolineThunks.cpp:226
+  // Insert EntryMBB into MF. It's not in the module until we do this.
+  MF.insert(MF.begin(), EntryMBB);
 }
----------------
using `end()` would seem a touch more idiomatic to me? Clearly doesn't actually matter much...


https://reviews.llvm.org/D46330





More information about the llvm-commits mailing list