[PATCH] D46277: [libFuzzer] Report at most one crash per input.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 13:21:40 PDT 2018


kcc added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common.cc:353
+
+
 SANITIZER_INTERFACE_ATTRIBUTE
----------------
redundant empty line


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h:59
+  // simultaneously.
+  SANITIZER_INTERFACE_ATTRIBUTE bool __sanitizer_acquire_crash_state();
+
----------------
Since this is used by libFuzzer, it's not an internal interface, but a public one, so move it to include/sanitizer/common_interface_defs.h
Also, make it return int, to make more C-friendly, update the comment accordingly. 


================
Comment at: compiler-rt/test/fuzzer/AcquireCrashStateTest.cpp:10
+
+extern "C" bool __sanitizer_acquire_crash_state();
+extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
----------------
Instead of this, include sanitizer/common_interface_defs.h


https://reviews.llvm.org/D46277





More information about the llvm-commits mailing list