[PATCH] D46259: [CFLGraph][NFC] Simplify/reorder switch in visitConstantExpr

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

Okay, so the actual code changes here are:

- combining the redundant Insert{Element,Value} and Extract{Element,Value} cases, which is good,
- eliminating some unnecessary temporary variables from some of the cases, which is also good, and
- reordering all the cases, which doesn't seem to be an improvement in any way and makes it harder to recognize the first two.

Why don't you submit a patch with just the first two changes?


https://reviews.llvm.org/D46259