[PATCH] D44598: [lit] Report line number for failed RUN command

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 12:29:35 PDT 2018


jdenny added a comment.

In https://reviews.llvm.org/D44598#1084413, @stella.stamenova wrote:

> In https://reviews.llvm.org/D44598#1084281, @jdenny wrote:
>
> > I've attempted to replace the ":" command with "echo > null" in the case of windows cmd.exe.  I don't build on windows, so someone else will have to try it, or we can let the buildbots tell us if windows is happy now.
>


I meant "echo > nul", but the code had it right.

> The tests work correctly on our setup (Windows 10/Python 3).

Good to know!  Thanks!

Before committing, I'll wait a bit for a code review as I made some small but non-trivial changes.


https://reviews.llvm.org/D44598





More information about the llvm-commits mailing list