[PATCH] D46315: [RegUsageInfoCollector] Fix handling of callee saved registers with CSR optimization.

Vivek Pandya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 1 11:28:07 PDT 2018


vivekvpandya resigned from this revision.
vivekvpandya added a comment.

I don't understand if this change address any correctness issue. If this in response to recent test failures you discovered for SystemZ then I think those tests are failing because SystemZ::determineCalleeSaves() did not do job as per expectation. Also your proposed change uses getCalleeSavedRegs() and it adds a loop however previous change is using getCallPreservedMask() which is faster.
It is better to get this reviewed from more experience person in register allocation.


https://reviews.llvm.org/D46315





More information about the llvm-commits mailing list