[PATCH] D42759: [CGP] Split large data structres to sink more GEPs

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:278
+    /// Map serial numbers to Large offset GEPs.
+    DenseMap<GetElementPtrInst *, int> LargeOffsetGEPID;
+
----------------
efriedma wrote:
> efriedma wrote:
> > Probably these maps should also use AssertingVH.
> By "these maps", I meant NewGEPBases and LargeOffsetGEPMap too.
LargeOffsetGEPMap still has a `GetElementPtrInst *` that isn't an AssertingVH.


Repository:
  rL LLVM

https://reviews.llvm.org/D42759